cli: fix breaking change on vulnerability hashes #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
fix-breaking-change
branch
from
56f5772 to
046c8d3
Compare
matheusalcantarazup
force-pushed
the
fix-breaking-change
branch
from
046c8d3 to
af4a160
Compare
iancardosozup
approved these changes
Oct 14, 2021
matheusalcantarazup
force-pushed
the
fix-breaking-change
branch
3 times, most recently
from
0e044e0 to
092e490
Compare
|
The pr 113 from devkit is required to build this pr |
matheusalcantarazup
force-pushed
the
fix-breaking-change
branch
from
092e490 to
0027aa2
Compare
matheusalcantarazup
force-pushed
the
fix-breaking-change
branch
from
0027aa2 to
58e4a20
Compare
On pr #636 we add the rule id on description of vulnerability, but the Details of vulnerability is used to generate the vulnerability hash, so adding the rule id on details generate a different hash which cause a breaking change. So this commit remove the rule id prefix from Details field of Vulnerability and also add a workaround to users that is already using the new hash as a false positive and risk accept. To support the two ways of hashing the vulnerability a new field was added on Vulnerability struct that represents the breaking way, so we generate the two hashes of vulnerability and when we set the vulnerability to false positive/risk accept according to config file we use the two hashes to match. Fixes #680 Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
fix-breaking-change
branch
from
58e4a20 to
7ae4e77
Compare
wiliansilvazup
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
On pr #636 we add the rule id on description of vulnerability, but the
Details of vulnerability is used to generate the vulnerability hash, so
adding the rule id on details generate a different hash which cause a
breaking change. So this commit remove the rule id prefix from Details
field of Vulnerability and also add a workaround to users that is
already using the new hash as a false positive and risk accept.
To support the two ways of hashing the vulnerability a new field was
added on Vulnerability struct that represents the breaking way, so we
generate the two hashes of vulnerability and when we set the
vulnerability to false positive/risk accept according to config file we
use the two hashes to match.
Fixes #680
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- How to verify it
- Description for the changelog